Skip to content

Conversation

@ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Jul 22, 2025

Fixed issues found in QA from #844:

  • If the sidebar is hidden at "No Item Selected", the switch cannot be displayed.
    • Entering the extension page from Safari settings (by reduce competition conditions)
    • If items are empty (by prevent hide sidebar)
  • Can resize sidebar in the settings modal opened (by reduce z-index)

@ACTCD ACTCD requested a review from Copilot July 22, 2025 17:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes several issues found in QA testing, focusing on user experience improvements and bug fixes. The changes address item activation logic, UI interaction validation, and z-index layer management.

Key changes:

  • Improved item activation validation by removing state dependency and adding null checks
  • Added validation to prevent hiding sidebar when no item is selected
  • Adjusted z-index values for UI layering and removed dropdown positioning attribute

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Sidebar.svelte Updated item activation logic and dropdown positioning
App.svelte Added sidebar toggle validation and adjusted z-index values

@ACTCD ACTCD merged commit 7f01558 into main Jul 22, 2025
1 check passed
@ACTCD ACTCD deleted the editor-sidebar-resize branch July 22, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants