Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build and development improvements #478

Open
wants to merge 13 commits into
base: v5
Choose a base branch
from
Open

chore: build and development improvements #478

wants to merge 13 commits into from

Conversation

quoid
Copy link
Owner

@quoid quoid commented May 1, 2023

Reference each commit for what was done. This PR should be rebased into v5 to ensure each commit is present in the history.

@quoid quoid requested a review from ACTCD May 1, 2023 20:42
@Citizen2023
Copy link

Citizen2023 commented May 1, 2023 via email

@quoid
Copy link
Owner Author

quoid commented May 1, 2023

@Citizen2023 v5 is in progress and will take many months to complete. Feel free to clone and build on your own system. Please keep comments in the PR thread specific to the code changes in the PR.

@Citizen2023
Copy link

Citizen2023 commented May 2, 2023 via email

Copy link
Collaborator

@ACTCD ACTCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just part review of the first commit, which I will do in multiple times.

.prettierrc Outdated Show resolved Hide resolved
.prettierrc Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
@quoid quoid requested a review from ACTCD May 3, 2023 00:34
@kainankidd

This comment was marked as off-topic.

@quoid
Copy link
Owner Author

quoid commented May 14, 2023

@kainankidd

Could you add the option to group/folder scripts by site? The interface's quite a mess when you've installed a multitude of scripts in the settings.

To be clear the feature you are requesting is to dynamically generate filter dimensions based off of the data a user has in their scripts and allow the user to filter against these dimensions in some unmentioned area of the extension (popup or page).

Also, if a tab menu could separate scripts and styles on the extension menu, that would be awesome.

The second feature request is to separate style and js user scripts specifically with tabs in the extension menu (popup?)

Either way, this is not the place to ask for feature enhancements, you can do that in the discussions or issues area.

Thanks 😄

.eslintrc.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants