Core: Throw an error when hooks are added outside of their module #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
requested changes
Apr 10, 2021
There was a problem hiding this comment.
LGTM. Naturally will land a bit later as we're not yet in the homestretch to QUnit 3.0.
But, we could land an alternate version in QUnit 2.x now, with a warning. That way, people can smoothly update to the last 2.x release, and there take their time to address any warnings whilst builds remain passing, and then move to 3.0 without no changes or other surprises.
Krinkle
changed the title
Krinkle
force-pushed
the
error-when-hooks-referenced-in-wrong-module
branch
from
9549683
to
fdcabba
Compare
Krinkle
pushed a commit
to raycohen/qunit
that referenced
this pull request
Jun 7, 2024
Change deprecation warning into an error. Ref qunitjs#1576 Closes qunitjs#1578
Krinkle
pushed a commit
to raycohen/qunit
that referenced
this pull request
Jun 7, 2024
Change deprecation warning into an error. Ref qunitjs#1576 Closes qunitjs#1578
Krinkle
force-pushed
the
error-when-hooks-referenced-in-wrong-module
branch
from
fdcabba
to
35f0beb
Compare
Krinkle
added a commit
that referenced
this pull request
Jun 7, 2024
Change deprecation warning into an error. Ref #1576 Closes #1578 Co-authored-by: Ray Cohen <[email protected]>
Krinkle
pushed a commit
to raycohen/qunit
that referenced
this pull request
Jun 8, 2024
Change deprecation warning into an error. Ref qunitjs#1576 Closes qunitjs#1578
Krinkle
force-pushed
the
error-when-hooks-referenced-in-wrong-module
branch
from
35f0beb
to
ad8bab0
Compare
Change deprecation warning into an error. Ref qunitjs#1576 Closes qunitjs#1578
Krinkle
force-pushed
the
error-when-hooks-referenced-in-wrong-module
branch
from
ad8bab0
to
c0e123b
Compare
Krinkle
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1576
For QUnit version 3.0