New Connector: MySql CDC Source - #955
Open
tim-quix wants to merge 2 commits into
Open
Conversation
gwaramadze
reviewed
Sep 15, 2025
Comment on lines
+37
to
+46
| **{ | ||
| "host": host, | ||
| "port": port, | ||
| "user": user, | ||
| "password": password, | ||
| "database": database, | ||
| "table": table, | ||
| "snapshot_host": snapshot_host or host, | ||
| "state_dir": state_dir, | ||
| } |
Contributor
There was a problem hiding this comment.
I think it doesn't need to be a dict
Suggested change
| **{ | |
| "host": host, | |
| "port": port, | |
| "user": user, | |
| "password": password, | |
| "database": database, | |
| "table": table, | |
| "snapshot_host": snapshot_host or host, | |
| "state_dir": state_dir, | |
| } | |
| host=host, | |
| port=port, | |
| user=user, | |
| password=password, | |
| database=database, | |
| table=table, | |
| snapshot_host=snapshot_host or host, | |
| state_dir=state_dir, |
| "Initial snapshot is enabled and not yet completed - performing snapshot..." | ||
| ) | ||
|
|
||
| if not self.is_snapshot_completed() or self.force_snapshot: |
Contributor
There was a problem hiding this comment.
There is a bit of redundant logic here because is_snapshot_completed also checks self.force_snapshot. If you ask me, the method should not check force_snapshot, it should only check actual completeness, not if the snapshot should be done forcefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from PR quixio/quix-samples#620 (made changes to be more in line with typical Source pattern).