Fix hash for value objects with in value objects

quiqueporta · Sep 5, 2018 · 5c59448 · 5c59448
1 parent b410f00
commit 5c59448
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,6 +1,11 @@
 Changelog
 =========
 
+1.1.1 (2015-09-05)
+------------------
+
+- Fix hash for value objects within value objects.
+
 1.1.0 (2018-09-04)
 ------------------
 

diff --git a/README.rst b/README.rst
@@ -187,7 +187,7 @@ Test
     > PYTHONPATH=$PYTHONPATH:. mamba
 
 
-.. |Version Number| image:: https://img.shields.io/badge/version-1.1.0-blue.svg
+.. |Version Number| image:: https://img.shields.io/badge/version-1.1.1-blue.svg
 
 .. |Build Status| image:: https://travis-ci.org/quiqueporta/simple-value-object.svg?branch=master
     :target: https://travis-ci.org/quiqueporta/simple-value-object

diff --git a/simple_value_object/__init__.py b/simple_value_object/__init__.py
@@ -3,7 +3,7 @@
 from .value_object import ValueObject
 from .decorators import invariant
 
-VERSION = (1, 1, 0, 'final')
+VERSION = (1, 1, 1, 'final')
 __version__ = VERSION
 
 

diff --git a/simple_value_object/value_object.py b/simple_value_object/value_object.py
@@ -107,10 +107,12 @@ def __repr__(self):
 
         return "{}({})".format(self.__class__.__name__, ", ".join(args_values))
 
+    def __hash__(self):
+        return self.hash
 
     @property
     def hash(self):
-        return hash(self.__class__) and hash(frozenset(self.__dict__.items()))
+        return hash(repr(self))
 
 
 class ArgsSpec(object):

diff --git a/specs/value_object_spec.py b/specs/value_object_spec.py
@@ -68,6 +68,11 @@ def __init__(self, x, y=3):
             expect(a_money).to(equal(Money(100, Currency('€'))))
             expect(a_money.currency).to(equal(Currency('€')))
 
+        with it('can compare hash for value objects within value objects'):
+            a_money = Money(100, Currency('€'))
+            another_money = Money(100, Currency('€'))
+            expect(a_money.__hash__()).to(equal(another_money.__hash__()))
+
         with it('provides a representation'):
             class MyPoint(ValueObject):
                 def __init__(self, x, y=3):