Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inference hazard for integer comparisons #2188

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

djc
Copy link
Member

@djc djc commented Mar 25, 2025

Fixes #2186.

The deranged maintainer appears to be unlikely to revert the new PartialEq impls that are causing this. I'm guessing this is not causing downstream issues because only dev-dependencies are pulling in the deranged crate, so there should be no urgent need for a release.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, honestly seems more readable anyway.

The deranged maintainer

That seems a bit harsh! Oh, wait.

@Ralith Ralith added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit f7e321c Mar 25, 2025
20 checks passed
@Ralith Ralith deleted the inference-hazard branch March 25, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI jobs broken due to conflicting implementation from deranged
3 participants