Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version Cargo lockfile #2187

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Version Cargo lockfile #2187

merged 2 commits into from
Mar 24, 2025

Conversation

djc
Copy link
Member

@djc djc commented Mar 24, 2025

To mitigate #2186.

mxinden
mxinden approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what my review is worth, very much in favor of checking in Cargo.lock, even beyond the direct bug fix this is targeting.

@djc djc mentioned this pull request Mar 24, 2025
Closed
Ralith
Ralith approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this is idiomatic these days 👍

We may need to fiddle with dependabot to make it not spammy.

@djc djc added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit 1c27b02 Mar 24, 2025
20 checks passed
@djc djc deleted the locked branch March 24, 2025 16:02
@larseggert larseggert mentioned this pull request Mar 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@mxinden mxinden mxinden approved these changes

@gretchenfrage gretchenfrage Awaiting requested review from gretchenfrage gretchenfrage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @Ralith @mxinden