WIP: Simple connect function #1250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Nov 30, 2021
|
|
||
| use crate::{ClientConfig, Connecting, Endpoint}; | ||
|
|
||
| /// Connect to `server_address`, authenticating it as `server_name`, using a new endpoint |
Member
There was a problem hiding this comment.
Seems reasonable, though I don't think it should live in its own module. Maybe an associated method for ClientConfig?
Member
|
@Ralith do you still want to work on this? If not, maybe close it? |
Collaborator
Author
|
In the years since I drafted this I'm still not sure it makes sense. Happy to close for now, trivial to reinvent it later if we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.