EIP-3074 Implementation #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
Mar 23, 2021
lightclient
force-pushed
the
eip-3074
branch
2 times, most recently
from
7a357f3
to
49c6963
Compare
Co-authored-by: [email protected] <[email protected]> Co-authored-by: Ansgar Dietrichs <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
|
Hi. I'm an app/solidity dev but have an interest in 3074 implementations due to a technical quirk of a contract I deployed in 2015. I'm keen to see the following in 3074 evm client implementations: TL;DR - I think it makes the most sense, in an AUTHCALL, for tx.origin to be set to the address of the account being remote-controlled, not the account initializing the transaction (i.e. paying the gas) as it is, in spirit, the remote-controlled address performing the action. I'm way out of my depth with your code, so a question: how does your implementation handle tx.origin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for an EIP-3074 implementation. WIP.