Matrix arithmetic in GF(2) #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleby
reviewed
Jan 29, 2020
| vector/bit) | ||
|
|
||
| (defun mod2+ (source1 source2 &optional target) | ||
| (binary-operator (lambda (x y) (mod (+ x y) 2)) source1 source2 target)) |
There was a problem hiding this comment.
Are x and y guaranteed to be bits? If so, maybe consider logxor.
|
Neat-o |
colescott
reviewed
Feb 18, 2020
| @@ -30,6 +32,7 @@ | |||
| ((subtypep type 'double-float) 'tensor/double-float) | |||
| ((subtypep type '(complex single-float)) 'tensor/complex-single-float) | |||
| ((subtypep type '(complex double-float)) 'tensor/complex-double-float) | |||
| ((subtypep type 'bit) 'tensor/bit) | |||
There was a problem hiding this comment.
The amount of repetition is making be think there must be a better way. Probably in a different PR.
There was a problem hiding this comment.
Yes, that is one of the reasons I paused this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic stuff.