Fix Error.stackTraceLimit = Infinity #861
Open
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarahm-ed
force-pushed
the
fix-stacktracelimit
branch
from
e458251 to
d80d0f1
Compare
saghul
reviewed
Jan 28, 2025
|
It seems that this works on mac but fails on Linux and Windows. |
|
Yes it seems like you'll have to go back to explicitly testing for infinity. |
ammarahm-ed
force-pushed
the
fix-stacktracelimit
branch
from
038177a to
340a457
Compare
|
@saghul can you start the tests again |
bnoordhuis
reviewed
Jan 29, 2025
saghul
reviewed
Jan 30, 2025
saghul
reviewed
Jan 30, 2025
|
Hey @saghul I didn't look closely at your diff in review, fixed now and all tests now pass. |
saghul
approved these changes
Jan 31, 2025
|
On a second thought, if we want to 100% mimic how v8 behaves we should store the JSValue and extract it when necessary. Right now if you set it to -Infinity you'll get back 0, whereas Chrome gets you back the same value you set. Thoughts @bnoordhuis ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #858