Skip to content

Conversation

Diniboy1123
Copy link

@Diniboy1123 Diniboy1123 commented Oct 11, 2025

Hey,

Mostly because of this, I thought it would be useful to bump the quic-go version used by the project. This comes with the unwanted side-effect that we have to bump the go version, but the README says support for the last two go versions, so it should still qualify.

Feel free to close the issue and do the bump yourself though if I missed something or edit this one.

I ran the tests+integrations and nothing seemed broken, so the update seemed trivial. I hope I didn't miss some changed APIs.

@marten-seemann
Copy link
Member

Not sure this is strictly necessary, users can just bump their quic-go dependency in their projects go.mod file. That said, it certainly doesn't hurt, so let's get this in.

Can you rebase this PR please? We had to get #50 in first.

@Diniboy1123
Copy link
Author

Apologies, didn't look at those workflows. Thanks for catching those! Should be rebased now.

My intention was to suppress the Github dependabot security alerts on my own fork without keeping too much difference between your stuff and mine. It's probably not a big deal, but better to have things up to date I think.

PS: While testing I noticed that the integration/README.md file mentions the wrong commands for the tests. Those should be make ping and make http. I didn't feel like it's worth opening another PR just because of that, but it might be useful for someone in the future.

@marten-seemann
Copy link
Member

PS: While testing I noticed that the integration/README.md file mentions the wrong commands for the tests. Those should be make ping and make http. I didn't feel like it's worth opening another PR just because of that, but it might be useful for someone in the future.

Please do!

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.68%. Comparing base (ad97770) to head (8930018).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   87.98%   87.68%   -0.30%     
==========================================
  Files           8        8              
  Lines         674      674              
==========================================
- Hits          593      591       -2     
- Misses         62       64       +2     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marten-seemann
Copy link
Member

I think you need to run go mod tidy, CI is unhappy.

@Diniboy1123
Copy link
Author

Strange... I ran it. Let's try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants