Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show repo count in marketplace UI (PROJQUAY-7185) #2875

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Marcusk19
Copy link
Contributor

@Marcusk19 Marcusk19 commented May 14, 2024

Change angular marketplace UI to show private repo count instead of SKU. Remove "Monthly" from section heading.

@Marcusk19
Copy link
Contributor Author

Marcusk19 commented May 14, 2024

@Marcusk19 Marcusk19 changed the title ui: show repo count in marketplace UI ui: show repo count in marketplace UI (PROJQUAY-7185) May 14, 2024
@Marcusk19 Marcusk19 marked this pull request as ready for review May 15, 2024 19:36
<div class="cor-loader-inline" ng-show="marketplaceLoading"></div>
<span ng-show="!organization && !marketplaceLoading">
<div ng-repeat="subscription in userMarketplaceSubscriptions">
{{subscription.quantity}}x {{ subscription.sku }}
{{subscription.quantity}}x {{ subscription.metadata.privateRepos }} private repos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we always get metadata and privateRepos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata should be always be there for user and org skus. As for privateRepos it should always be part of metadata since metadata is the equivalent plan that we have hardcoded in the billing section

Copy link
Contributor

@Sunandadadi Sunandadadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Marcusk19 Marcusk19 force-pushed the 05-14-ui_show_repo_count_in_marketplace_ui branch from fe96b0c to cb03570 Compare June 5, 2024 15:43
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (65e7270) to head (cb03570).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2875   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files         437      437           
  Lines       40852    40852           
  Branches     5354     5354           
=======================================
  Hits        28966    28966           
  Misses      10190    10190           
  Partials     1696     1696           
Flag Coverage Δ
unit 70.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marcusk19 Marcusk19 merged commit a35009a into master Jun 6, 2024
33 checks passed
Sunandadadi pushed a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants