Skip to content

libvuln: offline import performance improvements - #1986

Merged
github-actions[bot] merged 2 commits into
quay:mainfrom
hdonnay:hack/perf/offline_import
Aug 20, 2026
Merged

libvuln: offline import performance improvements#1986
github-actions[bot] merged 2 commits into
quay:mainfrom
hdonnay:hack/perf/offline_import

Conversation

@hdonnay

@hdonnay hdonnay commented Aug 14, 2026

Copy link
Copy Markdown
Member

This uses iterator interfaces to avoid buffering entire UpdateOperations in memory.

@hdonnay
hdonnay requested review from a team as code owners August 14, 2026 21:07
@hdonnay
hdonnay requested a review from crozzy August 14, 2026 21:07
@hdonnay
hdonnay force-pushed the hack/perf/offline_import branch from 571e0d3 to 5532603 Compare August 14, 2026 21:46
@hdonnay
hdonnay requested review from BradLugo and jvdm August 15, 2026 00:58
@hdonnay
hdonnay force-pushed the hack/perf/offline_import branch from 5532603 to 2e6555f Compare August 17, 2026 16:16
@hdonnay hdonnay added this to the Performance milestone Aug 17, 2026
@hdonnay
hdonnay force-pushed the hack/perf/offline_import branch from 2e6555f to 08f45bb Compare August 17, 2026 19:17
Comment thread libvuln/jsonblob/jsonblob.go
Comment thread libvuln/jsonblob/jsonblob.go

@crozzy crozzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this will be a nice upgrade

Comment thread libvuln/updates.go Outdated
Comment thread libvuln/jsonblob/jsonblob.go
Comment thread libvuln/updates.go Outdated
Comment thread libvuln/updates.go Outdated
Comment thread libvuln/offlineimport_test.go Outdated
Comment thread libvuln/jsonblob/jsonblob.go Outdated
@hdonnay
hdonnay force-pushed the hack/perf/offline_import branch 2 times, most recently from a88b024 to b578256 Compare August 18, 2026 19:20
@hdonnay
hdonnay requested review from crozzy and jvdm August 19, 2026 14:29
This has the goal of reducing peak memory usage.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: I387d9289aad128724e57b9cebd213a3c6a6a6964
This also adds a test that can be used to profile the import process.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: I387d9289aad128724e57b9cebd213a3c6a6a6964
@hdonnay
hdonnay force-pushed the hack/perf/offline_import branch from b578256 to 54e3a08 Compare August 20, 2026 17:50
@hdonnay

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@crozzy crozzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@hdonnay

hdonnay commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

/fast-forward

@github-actions
github-actions Bot merged commit 54e3a08 into quay:main Aug 20, 2026
10 checks passed
@hdonnay
hdonnay deleted the hack/perf/offline_import branch August 20, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants