toolkit: tools - #1812
Merged
Merged
Conversation
hdonnay
force-pushed
the
hack/toolkit-tools
branch
3 times, most recently
from
April 3, 2026 19:19
16e81d7 to
eb353fc
Compare
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: Ibc1ec2ee52d5ea220e665b96094e0a6b6a6a6964
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I4a2187faf63e35d06cf42d0898e5d60b6a6a6964
hdonnay
force-pushed
the
hack/toolkit-tools
branch
from
April 3, 2026 19:38
eb353fc to
55b60dc
Compare
crozzy
reviewed
Apr 3, 2026
| wfn, err := Unbind(in) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| t.Fatalf("%v: %#q", err, in) |
Contributor
There was a problem hiding this comment.
I think this is unreachable? I know it existed before
Member
Author
There was a problem hiding this comment.
Yeah, in theory we should never hit the error case because NVD validates the CPE Names, but better safe than sorry IMO
Contributor
|
What do you think about a weekly workflow for the dict production that creates a PR, would give us signal if the endpoint disappears again? (separate PR, I can add) |
Member
Author
|
I don't know how useful a periodic rebuild would be, mostly because it'd just be creating lots of binaries. We could not have the list gzipped, but it's massive: |
This also adds some format niceities. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I62fcc56ce568f5b22f6fb13f5c486b636a6a6964
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I8bf2e2bf57e3c8bbfe3a4ed684addb526a6a6964
hdonnay
force-pushed
the
hack/toolkit-tools
branch
from
April 6, 2026 14:47
55b60dc to
0c98432
Compare
crozzy
self-requested a review
April 6, 2026 15:26
crozzy
approved these changes
Apr 6, 2026
Member
Author
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
toolkitmodule to usinggo toolfor all thego generateinvocations.As part of this, I discovered that the XML-format CPE Dictionary is no longer available. The test and the fixture generator are updated accordingly.