Skip to content

libindex: layer metrics - #1794

Merged
github-actions[bot] merged 4 commits into
quay:mainfrom
hdonnay:push-lwtvrvmvostp
Apr 9, 2026
Merged

libindex: layer metrics#1794
github-actions[bot] merged 4 commits into
quay:mainfrom
hdonnay:push-lwtvrvmvostp

Conversation

@hdonnay

@hdonnay hdonnay commented Mar 26, 2026

Copy link
Copy Markdown
Member

This adds a set of metrics for tracking layer count, size, and request duration.

Additionally adds a package for helping with units, and fixes some lints flagged by revive.

@hdonnay
hdonnay requested a review from a team as a code owner March 26, 2026 18:45
@hdonnay
hdonnay requested review from crozzy and removed request for a team March 26, 2026 18:45
@hdonnay
hdonnay force-pushed the push-lwtvrvmvostp branch 4 times, most recently from d66b862 to ee5c38f Compare March 27, 2026 20:38

@crozzy crozzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

Comment thread libindex/instrumentation.go Outdated
@hdonnay
hdonnay force-pushed the push-lwtvrvmvostp branch 3 times, most recently from cf9796a to 757e664 Compare March 30, 2026 20:18
@hdonnay
hdonnay requested a review from crozzy March 31, 2026 00:21
@hdonnay
hdonnay force-pushed the push-lwtvrvmvostp branch 7 times, most recently from 7763ed7 to 944b53b Compare April 8, 2026 15:25

@crozzy crozzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hdonnay added 4 commits April 9, 2026 15:50
This establishes a central package to keep metric units consistent.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: I3821b242289d35e1ab4f8cf38f8063226a6a6964
JJ: See-Also: CLAIRDEV-NNNN
JJ: Closes: #NNNN
This will allow for users to to report metrics on cache size.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: I8acbc67d48a4c5ef5fdcd077c7ba7bf66a6a6964
This adds OpenTelemetry metrics to `RemoteFetchArena` instances.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: Iccaceed2a9099c23737892b0bea071506a6a6964
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Change-Id: Ie36484d4b76a2dba60cebeb260c3c22e6a6a6964
@hdonnay
hdonnay force-pushed the push-lwtvrvmvostp branch from 944b53b to 87f358a Compare April 9, 2026 20:50
@hdonnay

hdonnay commented Apr 9, 2026

Copy link
Copy Markdown
Member Author

/fast-forward

@github-actions
github-actions Bot merged commit 87f358a into quay:main Apr 9, 2026
6 checks passed
@hdonnay
hdonnay deleted the push-lwtvrvmvostp branch April 9, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants