enricher: add RHCC enricher #1057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
rhcc-enricher
branch
from
da2ddd0
to
91db57a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
==========================================
+ Coverage 56.25% 56.31% +0.05%
==========================================
Files 266 267 +1
Lines 16812 16828 +16
==========================================
+ Hits 9458 9477 +19
+ Misses 6391 6388 -3
Partials 963 963 ☔ View full report in Codecov by Sentry. |
crozzy
force-pushed
the
rhcc-enricher
branch
5 times, most recently
from
5aca24a
to
a6881c2
Compare
crozzy
force-pushed
the
rhcc-enricher
branch
2 times, most recently
from
27eb16c
to
9c10c91
Compare
|
The result is something like this: {
"message/vnd.clair.map.layer; enricher=clair.rhcc": [
{
"2": "sha256:013d2d7b1d1f8a94ffb762e6960fb5f483c60e38bd8740b1ec1f1a557d3d1bbf",
"4": "sha256:013d2d7b1d1f8a94ffb762e6960fb5f483c60e38bd8740b1ec1f1a557d3d1bbf",
"6": "sha256:d93e847446533e9af99b246c8cebea2527bf3e9db82e45fb59e3d9f1443a7d2c",
"8": "sha256:d93e847446533e9af99b246c8cebea2527bf3e9db82e45fb59e3d9f1443a7d2c"
}
]
}There are a couple of ways to do this, it could also be technically reversed. In that case we'd have to just consider binary packages (at the moment each RHCC layer has a source and a binary package describing it). I'm not sure what consumers of Clair would prefer. |
crozzy
force-pushed
the
rhcc-enricher
branch
2 times, most recently
from
eb59bba
to
90a888a
Compare
crozzy
commented
Jun 11, 2024
crozzy
force-pushed
the
rhcc-enricher
branch
2 times, most recently
from
f7156cc
to
c538f76
Compare
hdonnay
reviewed
Jun 12, 2024
crozzy
commented
Jun 13, 2024
enricher/rhcc/rhcc.go
Outdated
| func (e *Enricher) Enrich(ctx context.Context, g driver.EnrichmentGetter, r *claircore.VulnerabilityReport) (string, []json.RawMessage, error) { | ||
| problematicPkgs := make(map[string]string) | ||
| for id, _ := range r.Packages { | ||
| if envs, ok := r.Environments[id]; ok { |
There was a problem hiding this comment.
Just do binary packages
This change introduces a new enricher that reports where rhcc packages exist (if at all), it allows callers to discount vulnerabilities / packages that come from the same layers. This approach helps to keep the index report unchanged and therefore state is less of an issue, it also builds on existing machinary. Signed-off-by: crozzy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces an enricher who's purpose is to scope down the vulnerability report for layers that have RHCC packages. This approach helps to keep the index report unchanged and therefore state is less of an issue, it also builds on existing machinary.