Simplify TaskExtensions.IsCompletedSuccessfully(this Task t) #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
TaskExtensions.IsCompletedSuccessfully(this Task t)
we currently consider the task to be completed successfully if all of the following conditions are met:These last two conditions are not necessary as Status is only RanToCompletion if the task completed successfully.
I added unit tests for
TaskExtensions.IsCompletedSuccessfully(this Task t)
, but they may require a little tuning to get them to produce stable results.