-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add jackson-databind as a dependency of core-deployment #48890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Status for workflow
|
Let’s discuss it next week because it leaking to the test classpath is not ideal. |
There is no way around this, since |
Not required to be done in this PR, but if Jackson gets in core deployment, perhaps the JSON classes in core/builder/src/main/java/io/quarkus/builder/Json.java should be deprecated or removed? |
Perhaps... the builder module could be used outside the core, so Jackson wouldn't be available to those who only depend only on the builder. Another option is to move Jackson to the builder directly. |
There is a need to provide a JSON reader / writer (possible with data binding) to our deployment phase.
We do have internal implementations sitting here:
Mostly used to handle native image resources and build time metrics.
We now also have a json file that describes our configuration metadata (for tooling), but that we would benefit if consumed by our own build.
The proposal is to pick a popular JSON library to handle these uses cases instead of maintaining our own implementation. Since this is for the
deployment
phase only, it shouldn't leak to the runtime application, but it will be available in thetest
class path due tocore-deployment
being included inquarkus-junit5
.Additional discussion from Zulip: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/JSON.20dependency.20in.20the.20core.20deployment.3F/with/526854010