Add configuration option for a custom template directory #801
Conversation
FelixScherzinger
force-pushed
the
main
branch
from
fcf21d5
to
0732e50
Compare
| return getBaseDirRelativeToModule(config, getGlobalConfigName(INPUT_BASE_DIR), sourceDir); | ||
| } | ||
|
|
||
| private Optional<String> getTemplateBaseDirRelativeToModule(final Path sourceDir, final Config config) { |
There was a problem hiding this comment.
The template base directory must be relative to src/main/resources.
There was a problem hiding this comment.
The input base dir is also not relative to the resources folder. Shouldn't template and input base dir be handled in a similar way?
There was a problem hiding this comment.
IIRC, baseDir is not meant to be used by the templates but by the openapi folder on the src/main.
There was a problem hiding this comment.
I just generalized the method for getting a base dir for a certain config value for simplicity reasons.
There was a problem hiding this comment.
Yes, but in this case, we should evaluate if the templates will be distributed with your application.
- If the templates are distributed, they must be under
src/main/resources. - If not, under
src/main.
In both cases, the relative directory to the templates must not be under baseDir. So we should handle this directory you are introducing to this PR differently.
Currently the location for template files is fixed and cannot be altered to personal needs. With this PR template locations can be customized in a way like changing the opanpi file location via input-base-dir is already implemented