Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain config for Azure AI #698

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

duchamk
Copy link

@duchamk duchamk commented Jun 22, 2024

@duchamk duchamk requested a review from a team as a code owner June 22, 2024 13:58
@duchamk duchamk changed the title #660 added domain config for Azure AI added domain config for Azure AI Jun 22, 2024
@geoand
Copy link
Collaborator

geoand commented Jun 25, 2024

Thanks a lot!

@csotiriou do you want to review?

@geoand geoand changed the title added domain config for Azure AI Add domain config for Azure AI Jun 25, 2024
@geoand geoand merged commit 64701da into quarkiverse:main Jun 27, 2024
12 checks passed
@csotiriou
Copy link
Contributor

csotiriou commented Jun 27, 2024

@geoand @duchamk I approved this by mistake, sorry about that. I did find an issue.

Since this property is overridable, it should follow the same pattern as with endPointFor(), resourceNameFor(), and the @WithDefault would should only apply to the parent property, not the one that overrides the parent property.

Can we change that?

if not, I can create a new PR to alter this.

@geoand
Copy link
Collaborator

geoand commented Jun 27, 2024

No problem!

Feel free to do a follow-up PR

@geoand
Copy link
Collaborator

geoand commented Jun 27, 2024

@csotiriou ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure endpoint pattern domain name
4 participants