Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ollama devservice container to create an image with any configured model #683

Closed

Conversation

Malandril
Copy link

Allows ollama devservice container to create an image with any configured model.

This renames model tags replacing the : by _ so that the created image has a correctly named tag.

@Malandril Malandril requested a review from a team as a code owner June 16, 2024 13:27
@geoand
Copy link
Collaborator

geoand commented Jun 17, 2024

Thanks for the contribution.

Is there a reason you are using this instead of the zero-configuration Ollama support?

@Malandril
Copy link
Author

Running in tests in pipelines is easier with the devservices docker version as i don't have much to change compared to "classic" test containers pipelines.

But if is to be removed then, i guess i need to make an alternative setup.

@geoand
Copy link
Collaborator

geoand commented Jun 25, 2024

But if is to be removed then, i guess i need to make an alternative setup.

It will at some point because the developer experience is much worse than with the new way

@Malandril Malandril closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants