Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException: HttpClientPool in org.apache.cxf.Bus using VertxHttpClientHTTPConduitFactory #1598

Merged
merged 1 commit into from
Nov 14, 2024
Merged

NullPointerException: HttpClientPool in org.apache.cxf.Bus using VertxHttpClientHTTPConduitFactory #1598

merged 1 commit into from
Nov 14, 2024

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Nov 14, 2024

fix #1579

@ppalaga ppalaga requested a review from a team as a code owner November 14, 2024 10:44
@ppalaga ppalaga mentioned this pull request Nov 14, 2024
Closed
@famod
Copy link
Contributor

famod commented Nov 14, 2024 •
edited
Loading

Cool, I'll have a look soon.

Btw, I noticed

quarkus-cxf/extensions/core/runtime/src/main/java/io/quarkiverse/cxf/CxfClientProducer.java

Lines 65 to 66 in 2ae227a

@Inject
HttpClientPool httpClientPool;
which seems to be unused.
Is this a leftover?

@famod
Copy link
Contributor

famod commented Nov 14, 2024

Btw, I noticed

quarkus-cxf/extensions/core/runtime/src/main/java/io/quarkiverse/cxf/CxfClientProducer.java

Lines 65 to 66 in 2ae227a

@Inject
HttpClientPool httpClientPool;

which seems to be unused.
Is this a leftover?

Looks like a leftover from 8a8b2fe#diff-4a0749e6a75537378f516ce0aa6ef1514511d08f3a17c310bad5b55050727edaL188

famod
famod approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed!

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 14, 2024

in 1dc5aff I used the dangling HttpClientPool in CxfClientProducer to avoid looking up in Arc for every new client.

famod
famod approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested with 1dc5aff

@ppalaga ppalaga merged commit cf28c8c into quarkiverse:main Nov 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException: HttpClientPool in org.apache.cxf.Bus using VertxHttpClientHTTPConduitFactory
2 participants
@ppalaga @famod