Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize and compress transactions #1607

Merged
merged 27 commits into from
Aug 20, 2024
Merged

Conversation

ddimaria
Copy link
Collaborator

@ddimaria ddimaria commented Jul 24, 2024

  • JSON serialize and Zlib compress operations from core-to-client, client-to-multiplayer, multiplayer-to-client, and client-to-core
  • Handle binary operations in multiplayer and files
  • Update tests

Copy link

qa-wolf bot commented Jul 24, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Aug 14, 2024 5:59pm

@cla-bot cla-bot bot added the cla-signed label Jul 24, 2024
@ddimaria ddimaria changed the base branch from qa to bincode July 24, 2024 23:21
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1607 July 24, 2024 23:23 Inactive
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 80.53691% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (33bf2d7) to head (19d96a1).
Report is 201 commits behind head on qa.

Files Patch % Lines
...re/src/controller/execution/receive_multiplayer.rs 73.17% 11 Missing ⚠️
quadratic-multiplayer/src/message/handle.rs 70.00% 6 Missing ⚠️
quadratic-core/src/controller/transaction.rs 75.00% 5 Missing ⚠️
quadratic-rust-shared/src/pubsub/redis.rs 0.00% 5 Missing ⚠️
quadratic-multiplayer/src/message/response.rs 88.88% 1 Missing ⚠️
quadratic-rust-shared/src/pubsub/redis_streams.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1607      +/-   ##
==========================================
+ Coverage   90.62%   90.67%   +0.04%     
==========================================
  Files         192      192              
  Lines       38441    38670     +229     
==========================================
+ Hits        34838    35063     +225     
- Misses       3603     3607       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1607 July 26, 2024 23:09 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1607 July 29, 2024 19:16 Inactive
@ddimaria ddimaria marked this pull request as ready for review July 29, 2024 19:19
@davidkircos
Copy link
Collaborator

tested a 3.3mb Parquet file
On this branch is 8mb, previously it was 48mb! This is sweet.

Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing 0.5M file fails, this works in main and qa.
1M and above file fails on main and qa.
Files link: https://github.com/datablist/sample-csv-files

image

@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1607 August 13, 2024 21:36 Inactive
@ddimaria
Copy link
Collaborator Author

Can not download .grid file CleanShot 2024-08-09 at 16 17 36@2x

@davidkircos this is fixed. Please test once the branch deploys.

@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1607 August 13, 2024 23:39 Inactive
@davidkircos
Copy link
Collaborator

Can not download .grid file CleanShot 2024-08-09 at 16 17 36@2x

@davidkircos this is fixed. Please test once the branch deploys.

Downloading files seems to work for me!

@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1607 August 14, 2024 17:28 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1607 August 14, 2024 17:40 Inactive
@ddimaria
Copy link
Collaborator Author

Importing 0.5M file fails, this works in main and qa.
1M and above file fails on main and qa.
Files link: https://github.com/datablist/sample-csv-files

Resolved

@davidkircos davidkircos reopened this Aug 16, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1607 August 16, 2024 18:46 Inactive
@davidkircos davidkircos merged commit 50e68f8 into qa Aug 20, 2024
24 of 25 checks passed
@davidkircos davidkircos deleted the serialize-and-compress-transactions branch August 20, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants