-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize and compress transactions #1607
Conversation
ddimaria
commented
Jul 24, 2024
•
edited
Loading
edited
- JSON serialize and Zlib compress operations from core-to-client, client-to-multiplayer, multiplayer-to-client, and client-to-core
- Handle binary operations in multiplayer and files
- Update tests
…r, pubsub, and files
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## qa #1607 +/- ##
==========================================
+ Coverage 90.62% 90.67% +0.04%
==========================================
Files 192 192
Lines 38441 38670 +229
==========================================
+ Hits 34838 35063 +225
- Misses 3603 3607 +4 ☔ View full report in Codecov by Sentry. |
…ress-transactions
tested a 3.3mb Parquet file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing 0.5M file fails, this works in main and qa.
1M and above file fails on main and qa.
Files link: https://github.com/datablist/sample-csv-files
@davidkircos this is fixed. Please test once the branch deploys. |
Downloading files seems to work for me! |
Resolved |