Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1550 Replace node-kind() with new type-of() function #1570

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

1550 Replace node-kind() with new type-of() function #1570

wants to merge 4 commits into from

Conversation

michaelhkay
Copy link
Contributor

Drops the newly-introduced fn:node-kind() function in favour of a more general function fn:type-of().

@michaelhkay
Copy link
Contributor Author

Fix #1550

ChristianGruen
ChristianGruen approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ChristianGruen ChristianGruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. It reads like a good compromise.

@ChristianGruen ChristianGruen added the Tests Needed Tests need to be written or merged label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianGruen ChristianGruen ChristianGruen approved these changes

Assignees
No one assigned
Labels
Tests Needed Tests need to be written or merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhkay @ChristianGruen