Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tkl_f13_ansi_tsangan community layout to novelkeys/nk87* #24730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arcmags
Copy link
Contributor

@arcmags arcmags commented Dec 19, 2024

Description

The proper LAYOUTS variable was added to rules.mk for novelkeys/nk87 keyboards. These changes are necessary to easily compile corresponding keymaps in layouts/community/.

Sources

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be made in the keyboard.json file under the community_layouts key.

@arcmags arcmags requested a review from waffle87 December 20, 2024 03:48
@zvecr zvecr changed the title missing LAYOUTS added to novelkeys/nk87*/rules.mk Add tkl_f13_ansi_tsangan community layout to novelkeys/nk87* Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants