Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qwertykey75 #24683

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

qwertykey75 #24683

wants to merge 2 commits into from

Conversation

LiuLiuQMK
Copy link

Description

Add a Qwertykey75 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member

tzarc commented Dec 6, 2024

From the PR Checklist:


Wireless-capable boards:

  • Given license abuse from vendors, QMK does not accept any vendor PRs for wireless- or Bluetooth-capable keyboards without wireless and/or Bluetooth code
    • Historically, vendors have done this in bad faith in order to attain downstream VIA compatibility with no intention of releasing wireless sources
    • QMK's license, the GPL2+, requires full source disclosure for any distributed binary -- including full sources for any keyboard shipped by vendors containing QMK and/or firmware-side VIA code
    • If a vendor's wireless-capable keyboard PR submission is lacking wireless capability, then the PR will be left on-hold and unmergeable until wireless bindings are provided
    • If a vendor's wireless-capable keyboard is merged into QMK before it's known that the board is wireless, then all existing and future PRs from the same vendor will be put on hold until wireless bindings for the offending keyboard are provided

@tzarc tzarc marked this pull request as draft December 6, 2024 10:38
@tzarc tzarc added on hold no-ci Signals to the CI runners not to build. labels Dec 6, 2024
@LiuLiuQMK
Copy link
Author

This is just a simple wired keyboard

@LiuLiuQMK
Copy link
Author

My code does not involve any wireless functions at all, but please help me check the merge

@tzarc
Copy link
Member

tzarc commented Dec 7, 2024

Qwertykeys is a manufacturer listed on #24085 and as such this PR will not be reviewed until other wireless-capable QMK keyboards have been open-sourced. As stated on that issue:

If QMK identifies any licensing violation, all current and future PRs from that manufacturer will be put on hold until sources are provided. QMK's license requires full disclosure of source code for any firmware which is based on QMK, includes any part of QMK, or derives from QMK in any way. This source code disclosure is not negotiable and is automatically agreed to by any designer when they choose to use QMK.

You were warned on #24601 that submitting such boards wasn't appropriate -- at this point if there are further submissions your account will almost certainly be banned from participating in QMK.

Please engage with whoever is necessary to ensure the rest of the wireless boards made by Qwertykeys are open-sourced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crippled-firmware invalid keyboard keymap no-ci Signals to the CI runners not to build. on hold pr_checklist_pending Needs changes as per the PR checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants