Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added phnx keyboard #23748

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

added phnx keyboard #23748

wants to merge 21 commits into from
+280 −0

Conversation

sini6a
Copy link

@sini6a sini6a commented May 20, 2024

Description

Added custom unibody split ergonomic keyboard featuring 54 keys, each equipped with customizable addressable LEDs. Powered by ATMega and based on Miryoku.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 20, 2024
zvecr
zvecr requested changes May 20, 2024
View reviewed changes
keyboards/phnx/config.h Outdated Show resolved Hide resolved
keyboards/phnx/rules.mk Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/info.json Outdated Show resolved Hide resolved
keyboards/phnx/info.json Outdated Show resolved Hide resolved
keyboards/phnx/info.json Outdated Show resolved Hide resolved
zvecr
zvecr requested changes May 20, 2024
View reviewed changes
keyboards/phnx/info.json Outdated Show resolved Hide resolved
sini6a and others added 11 commits May 21, 2024 09:30
@sini6a @zvecr
Update keyboards/phnx/info.json
4808021 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/info.json
14fd5c0 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/info.json
db20e50 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/info.json
5c34cfd 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/keymaps/default/keymap.c
43d1f5e 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/keymaps/default/keymap.c
c2db701 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Rename LAYOUT_qwerty to LAYOUT
87b41c6 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Remove empty layouts
f1a774e 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/keymaps/via/config.h
c9befe0 
Co-authored-by: Joel Challis <[email protected]>
@sini6a @zvecr
Update keyboards/phnx/rules.mk
db4fdf3 
Co-authored-by: Joel Challis <[email protected]>
@sini6a
Delete keyboards/phnx/config.h
799d432
sini6a
sini6a commented May 21, 2024
View reviewed changes
Copy link
Author

@sini6a sini6a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions applied. Thanks for suggesting improvements!

waffle87
waffle87 requested changes May 24, 2024
View reviewed changes
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/phnx/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/phnx/readme.md Outdated Show resolved Hide resolved
keyboards/phnx/readme.md Outdated Show resolved Hide resolved
keyboards/phnx/readme.md Outdated Show resolved Hide resolved
sini6a
sini6a commented May 24, 2024
View reviewed changes
Copy link
Author

@sini6a sini6a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions applied. Thanks for pointing them out!

@sini6a sini6a requested a review from zvecr May 26, 2024 20:03
@sini6a
Copy link
Author

sini6a commented Jun 6, 2024

@zvecr is there anything else that I should change to be able to merge this?

drashna
drashna reviewed Jun 14, 2024
View reviewed changes
keyboards/phnx/info.json Outdated Show resolved Hide resolved
@sini6a
Copy link
Author

sini6a commented Jun 16, 2024

Done. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sini6a @drashna @zvecr @waffle87