Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_event_internal_probas out-of-bounds access #37

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Fix update_event_internal_probas out-of-bounds access #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions igor_src/Dinuclmarkov.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,7 @@ void Dinucl_markov::update_event_internal_probas(const Marginal_array_p& margina

for(Int_nt prev_nt: previous_list){
for(Int_nt next_nt : next_list){
this->dinuc_proba_matrix(i,j) += marginal_array[event_index + i*event_realizations.size() + j];
//TODO This is risky in case teh code evolves to ahve more than realizations
this->dinuc_proba_matrix(i,j) += marginal_array[event_index + prev_nt*event_realizations.size() + next_nt];
}
}
//By taking the average we assume all nucleotides underlying the ambiguous one are equally probable
Expand Down