Skip to content

Commit

Permalink
Merge pull request #37 from Thopic/update_event_internal_probas_fix
Browse files Browse the repository at this point in the history
Fix update_event_internal_probas out-of-bounds access in Dinucleotide model
  • Loading branch information
qmarcou authored Feb 5, 2019
2 parents ea04a6d + efe6185 commit 2e510d9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions igor_src/Dinuclmarkov.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,7 @@ void Dinucl_markov::update_event_internal_probas(const Marginal_array_p& margina

for(Int_nt prev_nt: previous_list){
for(Int_nt next_nt : next_list){
this->dinuc_proba_matrix(i,j) += marginal_array[event_index + i*event_realizations.size() + j];
//TODO This is risky in case teh code evolves to ahve more than realizations
this->dinuc_proba_matrix(i,j) += marginal_array[event_index + prev_nt*event_realizations.size() + next_nt];
}
}
//By taking the average we assume all nucleotides underlying the ambiguous one are equally probable
Expand Down

0 comments on commit 2e510d9

Please sign in to comment.