Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint and Mypy fixes to solve CI errors. Remove Python 3.8 support #1374

Merged
merged 21 commits into from
Jan 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This code is part of a Qiskit project.
#
# (C) Copyright IBM 2021, 2024.
# (C) Copyright IBM 2021, 2025.
#
# This code is licensed under the Apache License, Version 2.0. You may
# obtain a copy of this license in the LICENSE.txt file in the root directory
Expand Down Expand Up @@ -149,7 +149,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: [3.8, 3.9, '3.10', 3.11, 3.12]
python-version: [3.8, 3.9, 3.10, 3.11, 3.12]
include:
- os: macos-latest
python-version: 3.8
Expand All @@ -171,11 +171,14 @@ jobs:
requirements-dev.txt
- name: Create conda environment
run: |
echo user $USER
echo conda_dir $CONDA
which conda
if [ "${{ matrix.os }}" == "macos-latest" ]; then
sudo chown -R $USER: "$CONDA"
fi
source "$CONDA/etc/profile.d/conda.sh"
if [ "${{ matrix.python-version }}" >= "3.11" ]; then
if [ "${{ matrix.python-version }}" >= "3.9" ]; then
conda create -y -n psi4env python=${{ matrix.python-version }} -c conda-forge
else
conda create -y -n psi4env python=${{ matrix.python-version }}
Expand Down
Loading