Skip to content

Implement Data-reuploading classifier in Qiskit Machine Learning #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ShivaniRajput11
Copy link

Description

Data re-uploading is a recently proposed idea of quantum neural network, which uses a quantum circuit with a series of data re-uploading and processing layers. Unlike the conventional quantum circuit of quantum neural network, it has multiple layers of re-uploading input data. In this project, we will implement the data re-uploading quantum neural network in Qiskit Machine Learning. The goal of this project is to write code and create a pull request

Details and comments

The work is done in QAMP23 (qiskit-advocate/qamp-spring-23#3)

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adekusar-drl adekusar-drl added the on hold 🛑 Can not fix yet label Aug 30, 2023
@woodsp-ibm woodsp-ibm changed the title Implement Date-reuploading classifier in Qiskit Machine Learning Implement Data-reuploading classifier in Qiskit Machine Learning Nov 2, 2023
Copy link
Collaborator

@OkuyanBoga OkuyanBoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook needs to be updated for the unit tests:

  • Check spelling
  • Update outdated libraries

@edoaltamura edoaltamura added the type: enhancement ✨ Features or aspects to improve label Apr 3, 2024
@edoaltamura
Copy link
Collaborator

Hi @ShivaniRajput11, are you still interested in finishing this PR? There are just a few things left to change to make it compatible with the latest Qiskit ML version:

  • update from qiskit.utils import algorithm_globals
  • run the spellchecker and add unknown words to .pylintdict

@ShivaniRajput11
Copy link
Author

Hi @edoaltamura , yes I am still interested to finish this PR. I am working on it. Thanks.

Copy link
Collaborator

@edoaltamura edoaltamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the recent changes in Qiskit ML that would require changes in this PR:

  • from qiskit.utils import algorithm_globals: algorithm_globals is now hosted in Qiskit ML directly since the merge of Qiskit Algorithm last week.
  • A new tutorial, number 13, has been merged in the main branch, so this tutorial should be renamed with the number 14.
  • The V1 primitives are being deprecated across the Qiskit ecosystem and this change may affect SamplerQNN used here. Soon we will update Qiskit ML to reflect this upgrade, so this tutorial may need to be adjusted as well.

@edoaltamura edoaltamura marked this pull request as draft October 17, 2024 16:23
edoaltamura and others added 2 commits March 24, 2025 14:52
* Add support for `Python 3.13`

* Add note for tutorial tests

* Add support for `Python 3.13`

* Add note for tutorial tests

* Update .github/workflows/main.yml

Co-authored-by: Steve Wood <[email protected]>

* Update `def __eq__` in optimizers

* Implement the convention `def __eq__(self, other: object) -> bool:`

* Fix typos

* Fix shape in steppable optimizer

---------

Co-authored-by: Steve Wood <[email protected]>
@woodsp-ibm
Copy link
Member

woodsp-ibm commented May 30, 2025

Note: we ran into an issue on the main branch here a while back which resulted in us rolling back the main branch to an earlier commit and at the time main was renamed to oldmain as we created the new main branch from the earlier time. This PR is still targeting oldmain so in addition to whatever content updates were going to be done for this PR, if there is still any interest as there had been no activity in some months, it also needs to be done to the main branch that exists now. My take given how long this has been open and the branch change would be that perhaps this PR is best closed. A new PR using updated content from this, as per the above comments etc., can be opened if there is still interest.

Update: I edited the PR to retarget to main just in case. There is a conflict now. As I mentioned, if there is still interest, it may be better to apply your new content to a updated main and do a new PR.

@woodsp-ibm woodsp-ibm changed the base branch from oldmain to main June 10, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold 🛑 Can not fix yet type: enhancement ✨ Features or aspects to improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants