ENH: collate_loci action added #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misialq
reviewed
Dec 13, 2024
| LociDirectoryFormat) | ||
|
|
||
|
|
||
| def collate_loci(loci: LociDirectoryFormat) -> LociDirectoryFormat: |
There was a problem hiding this comment.
Hey @DorielaGrabocka, could you please simplify these loops to resemble the other collating actions we have in this plugin? There is one example in this file, at the bottom. Unless you had a reason to do it this way?
misialq
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Hey @DorielaGrabocka, could you please update the branch and resolve the conflict? Thanks! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR requested by @misialq
Adds
collate_lociaction. This action collates loci from different loci directories into a single LociDirectoryFormat and returns a GenomeData[Loci] artifact.