NEW: adds ImmutableMetadata semantic type and supporting formats #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizgehret
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Generally this all looks good @gregcaporaso! In terms of your question about whether this should be named ImmutableMetadata vs Metadata - I am leaning towards ImmutableMetadata just because that is a bit clearer in the intention behind adding this type and associated formats. I think that would also help folks distinguish between the Metadata class within QIIME 2 🤷♀️
|
That makes sense to me @lizgehret! I think we can merge this one when you're ready. |
lizgehret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to-do:
MetadataFormatandMetadataDirectoryFormat(i.e., drop theImmutablefrom the beginning of both, since there is nothing about the formats that differs from our regular metadata files)? looking for input on thisfixes #292
A little example of how this can be used:
$ qiime tools import \ --type ImmutableMetadata \ --input-format ImmutableMetadataFormat \ --input-path sample-metadata.tsv \ --output-path sample-metadata.qza $ qiime metadata tabulate \ --m-input-file sample-metadata.qza \ --o-visualization sample-metadata.qzv $ qiime tools export \ --input-path sample-metadata.qza \ --output-path md/