Skip to content

Update future semantics and fix hidden exceptions #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

AdvancedAntiSkid
Copy link
Member

@AdvancedAntiSkid AdvancedAntiSkid commented Mar 5, 2025

Summary by CodeRabbit

  • New Features

    • Rolled out updated asynchronous processes that now dynamically handle task execution and manage errors more gracefully.
  • Refactor

    • Streamlined background task completion methods for a simpler and more robust user experience.

Copy link

coderabbitai bot commented Mar 5, 2025

Warning

Rate limit exceeded

@AdvancedAntiSkid has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9131bb4 and c5885ef.

📒 Files selected for processing (1)
  • src/main/java/com/qibergames/futura/concurrent/future/Future.java (15 hunks)

Walkthrough

This pull request refactors the Future class by removing the completed(Supplier<T>) method and introducing a new supply(Supplier<T>) method. The asynchronous methods have been streamlined by removing explicit executor parameters, relying instead on the current thread’s stack trace. Additionally, a trySupply(ThrowableSupplier<T, Throwable>) method has been added, and error handling has been improved with finer distinctions between Throwable and Exception.

Changes

File Change Summary
src/.../Future.java - Removed completed(@NotNull Supplier<T> value) method.
- Added supply(@NotNull Supplier<T> result) and trySupply(@NotNull ThrowableSupplier<T, Throwable> result) methods.
- Updated signatures for completeAsync, supplyAsync, trySupplyAsync, and invokeAsync to simplify parameter usage and leverage thread context.
- Enhanced error handling in catch blocks.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Future
    participant Supplier

    Client->>Future: supply(Supplier)
    Future->>Supplier: Invoke get()
    alt Successful Completion
        Supplier-->>Future: Return result
        Future-->>Client: Complete Future with result
    else Exception Occurs
        Supplier-->>Future: Throw exception
        Future-->>Client: Complete Future with exception
    end
Loading

Possibly related PRs

Poem

I’m a rabbit in the code field, hopping with joy,
Methods are refactored – a cleaner deploy!
Out goes the old, in comes the new,
With error catching crisp and true.
My whiskers twitch at each neat rewrite,
Celebrating changes from morning till night! 🐇


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AdvancedAntiSkid AdvancedAntiSkid merged commit aab0cdd into master Mar 5, 2025
4 of 5 checks passed
@AdvancedAntiSkid
Copy link
Member Author

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant