-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(architecture): Disable non 64-bit architecture #60494
base: master
Are you sure you want to change the base?
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
We still build qfield for 32 bit android devices. |
@m-kuhn ah mince. Sounds like a good argument against this PR :/ |
Not a lot, it's marginal. If we lose support it's not the end of the world -- but why hard disable? |
@@ -62,6 +62,10 @@ set(COMPLETE_VERSION ${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINO | |||
set(RELEASE_NAME "Master") | |||
project(qgis VERSION ${COMPLETE_VERSION}) | |||
|
|||
if(NOT CMAKE_SIZEOF_VOID_P EQUAL 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More an educational comment than anything, but there are architectures, like CHERI, with 128-bit pointers: https://lwn.net/Articles/909265/ , so if we don't want to exclude them but just 32-bit, the test could be "CMAKE_SIZEOF_VOID_P EQUAL 4"
I've experimented that a bit with GDAL (for fun) ~ 2 years ago, and that mostly worked, except in all places where one serializes a pointer to text ( printf("%p) ) and deserialize it back to pointer ( sscanf("%p)" ).
I think we should close this. There's no strong benefit to dropping 32 bit right now, and a clear downside to doing so. |
Description
Support for 32-bit architectures is becoming increasingly obsolete. For QGIS:
-mllvm -inline-threshold=128
... This will be a good opportunity to start cleaning things up.To my knowledge, there is no official statement from QGIS explicitly dropping 32-bit support, apart from the information mentioned on the download page. But if there has been an official announcement that I missed, at least this formalizes it. 😄