Update RasterColorInterpretation enumeration with constants added in GDAL 3.10#58807
Merged
Merged
Conversation
Contributor
troopa81
approved these changes
Sep 20, 2024
Contributor
troopa81
left a comment
troopa81
left a comment
There was a problem hiding this comment.
Looks good to me
Not sure if this 3.40 or 3.42 material. I targetted the later for now
Would QGIS 3.40 be built depending on gdal 3.10? Maybe yes in the end, QGIS 3.40 being a LTR. So maybe it's better to have it in 3.40.
nyalldawson
reviewed
Sep 20, 2024
| return QStringLiteral( "Undefined" ); | ||
|
|
||
| case Qgis::RasterColorInterpretation::GrayIndex: | ||
| return QStringLiteral( "Gray" ); |
Collaborator
There was a problem hiding this comment.
Is there any reason why these aren't translated?
Contributor
Author
There was a problem hiding this comment.
Is there any reason why these aren't translated?
I was wondering too. colorInterpretationName() doesn't appear to be much used, except in QgsRasterInterface::displayBandName(), so it might be save to translate it
Collaborator
|
+1 to merging for 3.40 |
rouault
force-pushed
the
update_RasterColorInterpretation
branch
from
a109d23 to
00013ba
Compare
Contributor
Author
|
update to indicate since 3.40, and translate strings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per OSGeo/gdal#10721
Not sure if this 3.40 or 3.42 material. I targetted the later for now