-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't offer non-vector layer providers as options for virtual layer source layers #48988
Conversation
query the layer types supported by a data provider
…iders supporting a layer type
source layers Fixes qgis#48908
a virtual layer Refs qgis#48908
QgsMemoryProviderMetadata::QgsMemoryProviderMetadata() | ||
: QgsProviderMetadata( QgsMemoryProvider::providerKey(), QgsMemoryProvider::providerDescription() ) | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely cosmetic here: you could get rid of the empty line if you feel like waiting for another round of CIs to turn green again ;)
I've seen it elsewhere too (mesh provider for e.g.). I don't know if we have a convention on this or not. No problem if you leave those in.
Co-authored-by: Mathieu Pellerin <[email protected]>
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-48988-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 87232a823451a174547c83d299457f47d18b80af,c8347e34120ffa3cc88c2653b083b269500775e9,8e58188776436e40dbb8343586e63ae026883790,637852022040e46e17435257ebd126a77cb8284d,b1db5d91990d8fcaf905a947878895cb30cb5e75,fe4d499d8dd765df5436d0c1fb0fd1a70fa7f848,2e9f754a5b1a3c94d34e1fcee02103e3a5c049a5
# Push it to GitHub
git push --set-upstream origin backport-48988-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
This isn't supported, and results in a hang. Also cleanup and fix some more issues in the virtual layer provider.
Fixes #48908