Use QgsStatisticalSummary for merge attributes dialog #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a bunch of new stats and avoids code duplication
|
Cool, can we integrate it with the expression engine (aggregate functions would be great)? :-) Is there anything making you hesitate to merge it? |
|
@m-kuhn eventually yes... With some context magic that would be possible. Not on my list at the moment though! Re why not merge now: I thought I'd give the process outlined in qgis/QGIS-Enhancement-Proposals#52 a shot and see how it works in practice for something like this. |
|
Merged in df6c710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
Let me know if there's other areas of the code which have their own implementation of sum/mean/etc type calculations and I'll flip them over too.