WebUI: Limit window sizes to viewport size #22919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piccirello
commented
Jun 25, 2025
Comment on lines
-950
to
+951
| width: loadWindowWidth(id, 800), | ||
| height: loadWindowHeight(id, 650), | ||
| width: loadWindowWidth(id, 800, false), | ||
| height: loadWindowHeight(id, 650, false), |
There was a problem hiding this comment.
Viewport size limitations disabled for RSS downloader window. The height probably doesn't need to be limited, since it appears to support scrolling, but I figured this window's sizing can be handled later all at once.
Piccirello
commented
Jun 25, 2025
Piccirello
commented
Jun 25, 2025
| @@ -325,7 +336,7 @@ const initializeWindows = () => { | |||
| maximizable: false, | |||
| paddingVertical: 0, | |||
| paddingHorizontal: 0, | |||
| width: 424, | |||
| width: limitWidthToViewport(424), | |||
| height: 100 | |||
There was a problem hiding this comment.
I opted not to add the limiter to the vast majority of window heights since they're already so small.
This was referenced Jun 25, 2025
This change makes the WebUI easier to use on small screens (e.g. mobile). Every window has been tested for compatibility.
Piccirello
force-pushed
the
webui-window-size
branch
from
6494977 to
fff8c68
Compare
Closed
Chocobo1
approved these changes
Jul 4, 2025
thalieht
approved these changes
Jul 5, 2025
|
@Piccirello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the WebUI easier to use on small screens (e.g. mobile). In cases where the window's default size is larger than the user's screen, the window will be resized appropriate (see example below). Every window has been tested for compatibility. The only windows that don't support this are the multi file rename window and the RSS Downloader window.
Height and width auto resized to fit on screen w/ small margin:
Closes #19813