-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA CI: fix AppImage building #22286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier2k6
previously approved these changes
Feb 15, 2025
glassez
previously approved these changes
Feb 15, 2025
Upstream now defaults to static runtime and the previous URL is invalid now. Upstream commits: linuxdeploy/linuxdeploy@c28054b linuxdeploy/linuxdeploy-plugin-qt@ce5291e Also fuse2 is not needed now as stated on: https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime-
36d8d0a
to
7287815
Compare
PR Updated to remove a redundant dependency. This PR is final. |
xavier2k6
approved these changes
Feb 15, 2025
I'll merge this early to fix the failing CI. |
@glassez |
Only in 5.1? Or in 5.0 too? |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Feb 16, 2025
Upstream now defaults to static runtime and the previous URL is invalid now. Upstream commits: * linuxdeploy/linuxdeploy@c28054b * linuxdeploy/linuxdeploy-plugin-qt@ce5291e Also fuse2 is not needed now as stated on: https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime- PR qbittorrent#22286.
Both if it can be easily cherry-picked. |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Feb 16, 2025
Upstream now defaults to static runtime and the previous URL is invalid now. Upstream commits: * linuxdeploy/linuxdeploy@c28054b * linuxdeploy/linuxdeploy-plugin-qt@ce5291e Also fuse2 is not needed now as stated on: https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime- PR qbittorrent#22286.
glassez
added a commit
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream now defaults to static runtime and the previous URL is invalid now.
Upstream commits:
Also fuse2 is not needed now as stated on:
https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime-