Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA CI: fix AppImage building #22286

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Feb 15, 2025

Upstream now defaults to static runtime and the previous URL is invalid now.
Upstream commits:

Also fuse2 is not needed now as stated on:
https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime-

@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Feb 15, 2025
@Chocobo1 Chocobo1 marked this pull request as ready for review February 15, 2025 15:26
xavier2k6
xavier2k6 previously approved these changes Feb 15, 2025
glassez
glassez previously approved these changes Feb 15, 2025
Upstream now defaults to static runtime and the previous URL is invalid
now.
Upstream commits:
linuxdeploy/linuxdeploy@c28054b
linuxdeploy/linuxdeploy-plugin-qt@ce5291e

Also fuse2 is not needed now as stated on:
https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime-
@Chocobo1
Copy link
Member Author

PR Updated to remove a redundant dependency. This PR is final.

@Chocobo1
Copy link
Member Author

I'll merge this early to fix the failing CI.

@Chocobo1 Chocobo1 merged commit ddf6dd5 into qbittorrent:master Feb 15, 2025
15 checks passed
@Chocobo1 Chocobo1 deleted the ci_appimage branch February 15, 2025 21:08
@Chocobo1
Copy link
Member Author

@glassez
Please backport this PR. Thanks!

@glassez
Copy link
Member

glassez commented Feb 16, 2025

@glassez Please backport this PR. Thanks!

Only in 5.1? Or in 5.0 too?

glassez pushed a commit to glassez/qBittorrent that referenced this pull request Feb 16, 2025
Upstream now defaults to static runtime and the previous URL is invalid now.
Upstream commits:
* linuxdeploy/linuxdeploy@c28054b
* linuxdeploy/linuxdeploy-plugin-qt@ce5291e

Also fuse2 is not needed now as stated on:
https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime-

PR qbittorrent#22286.
@Chocobo1
Copy link
Member Author

Only in 5.1? Or in 5.0 too?

Both if it can be easily cherry-picked.

glassez pushed a commit to glassez/qBittorrent that referenced this pull request Feb 16, 2025
Upstream now defaults to static runtime and the previous URL is invalid now.
Upstream commits:
* linuxdeploy/linuxdeploy@c28054b
* linuxdeploy/linuxdeploy-plugin-qt@ce5291e

Also fuse2 is not needed now as stated on:
https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime-

PR qbittorrent#22286.
glassez added a commit that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants