This repository was archived by the owner on Dec 29, 2024. It is now read-only.
Velan gremgo #49
Open
Velan gremgo #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2019 12:50
…nged to IsConnected()
qasaur
suggested changes
Feb 22, 2019
connection.go
Outdated
| @@ -10,7 +10,8 @@ import ( | |||
|
|
|||
| type dialer interface { | |||
| connect() error | |||
| isConnected() bool | |||
| //Changed this method to Isconnected from isconnected to make it avail as public method | |||
There was a problem hiding this comment.
Remove this comment, the commit message already says what you have done, and the capitalization already gives an indication that the method is public.
connection.go
Outdated
| @@ -72,8 +73,8 @@ func (ws *Ws) connect() (err error) { | |||
| } | |||
| return | |||
| } | |||
|
|
|||
| func (ws *Ws) isConnected() bool { | |||
| //Changed this method to Isconnected from isconnected to make it avail as public method | |||
There was a problem hiding this comment.
I have removed the comments as you mentioned above
qasaur
approved these changes
Feb 26, 2019
|
Would be great if this was merged 🙌 |
|
Is tat above change get merged into master?? Still I couldn't see the changes in master, If its not yet merged can some one help me in merging this to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
I have changed the isConnected function from the connection.go file to IsConnected() I mean to say I have made the isConnected function as public to make sure whether the my connection is successful or not.
Regards
velan