Skip to content

Fixed Compatibility issues #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ The keys above are not valid, so don't try to use them.
#### 1. Clone the repository

```
git clone https://github.com/pzinsta/pizzeria.git
git clone https://github.com/omarkashour/QAProject
```

#### 2. Build the .war file
Expand Down Expand Up @@ -115,16 +115,9 @@ We have two options here.
If you've set the properties as environment variables, you can run the following command to start the app:

```
java -jar webapp/target/dependency/webapp-runner.jar --port 8081 --path pizzeria webapp/target/*.war
java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED -jar webapp/target/dependency/webapp-runner.jar --port 8081 --path pizzeria webapp/target/*.war
```

##### Option 2. Pass the properties as JVM arguments

In this case the command is going to be a bit more complicated.

```
java -Dbraintree.merchantId=<your Braintree merchant ID> -Dbraintree.publicKey=<your Braintree public key> -Dbraintree.privateKey=<your Braintree private key> -Drecaptcha.private.key=<your reCAPTCHA private key> -Drecaptcha.public.key=<your reCAPTCHA public key> -jar webapp/target/dependency/webapp-runner.jar --port 8081 --path pizzeria webapp/target/*.war
```

You can modify the port and the context path. Also, there are other [options](https://github.com/jsimone/webapp-runner#options) available.

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<hibernate-validator.version>6.0.7.Final</hibernate-validator.version>
<log4j.version>2.9.1</log4j.version>
<junit.version>4.12</junit.version>
<mockito.version>2.10.0</mockito.version>
<mockito.version>5.14.2</mockito.version>
<postgres.version>42.1.4</postgres.version>
<apache.commons-lang.version>3.6</apache.commons-lang.version>
<apache.commons-collections.version>4.1</apache.commons-collections.version>
Expand Down
22 changes: 22 additions & 0 deletions webapp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,28 @@
<artifactId>service-impl</artifactId>
<version>0.0.1-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>2.3.1</version>
</dependency>
<dependency>
<groupId>com.sun.xml.bind</groupId>
<artifactId>jaxb-impl</artifactId>
<version>2.3.1</version>
</dependency>
<dependency> <groupId>jakarta.xml.bind</groupId> <artifactId>jakarta.xml.bind-api</artifactId> <version>2.3.3</version> </dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<version>2.3.1</version>
</dependency>
<dependency>
<groupId>javax.activation</groupId>
<artifactId>activation</artifactId>
<version>1.1.1</version>
</dependency>

<dependency>
<groupId>pzinsta</groupId>
<artifactId>dao-impl</artifactId>
Expand Down