Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS branch remastering #1213

Draft
wants to merge 115 commits into
base: atspi
Choose a base branch
from
Draft

Conversation

dariacher
Copy link

No description provided.

.github/workflows/python-package.yml Outdated Show resolved Hide resolved
.github/workflows/python-package.yml Outdated Show resolved Hide resolved
examples/macos/os_update.py Outdated Show resolved Hide resolved
examples/macos/itunes.py Outdated Show resolved Hide resolved
store.click()

time.sleep(5)
dlg.Search.type_keys('michael jackson')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this example uses click which beaves different way than click_input, I'd suggest to use set_edit_text instead of type_keys which requires input focus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's good to see other methods in the examples. Not only click and entering text.

pywinauto/macos/macos_structures.py Outdated Show resolved Hide resolved
if sys.platform == 'win32':
from .windows.mouse import MouseEvent, MouseHook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we missed MouseEvent, MouseHook which are implemented for Windows. Need to review it.

pywinauto/unittests/macos/test_ax_element_info_macos.py Outdated Show resolved Hide resolved
pywinauto/unittests/macos/test_ax_wrapper.py Outdated Show resolved Hide resolved
@dariacher dariacher force-pushed the mac_coverage branch 15 times, most recently from 5de9858 to 25ed92e Compare May 16, 2022 03:31
@dariacher dariacher force-pushed the mac_coverage branch 3 times, most recently from dd54772 to 03e6396 Compare May 23, 2022 16:35
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1213 (31f2d43) into atspi (92aa550) will decrease coverage by 12.24%.
The diff coverage is 5.69%.

❗ Current head 31f2d43 differs from pull request most recent head 1b1bf91. Consider uploading reports for the commit 1b1bf91 to get more accurate results

@@             Coverage Diff             @@
##            atspi    #1213       +/-   ##
===========================================
- Coverage   87.88%   75.64%   -12.25%     
===========================================
  Files          60       70       +10     
  Lines       23019    24491     +1472     
===========================================
- Hits        20231    18525     -1706     
- Misses       2788     5966     +3178     

@dariacher dariacher force-pushed the mac_coverage branch 10 times, most recently from d48ce03 to e8eaeec Compare May 28, 2022 14:44
@dariacher dariacher force-pushed the mac_coverage branch 3 times, most recently from 0dd9195 to 31f2d43 Compare June 12, 2022 15:20
@abrichr
Copy link

abrichr commented May 27, 2023

Thanks @vasily-v-ryabov ! What is remaining in order for this to be merged?

@vasily-v-ryabov
Copy link
Contributor

First conflicts should be resolved, also Circle CI should be used with SIP-disabled image to enable accessibility programmatically, then setup.py review is necessary to update actual pyobjc versions that work on the vast majority of macOS versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants