-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS branch remastering #1213
base: atspi
Are you sure you want to change the base?
macOS branch remastering #1213
Conversation
store.click() | ||
|
||
time.sleep(5) | ||
dlg.Search.type_keys('michael jackson') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this example uses click
which beaves different way than click_input
, I'd suggest to use set_edit_text
instead of type_keys
which requires input focus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it's good to see other methods in the examples. Not only click
and entering text.
if sys.platform == 'win32': | ||
from .windows.mouse import MouseEvent, MouseHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we missed MouseEvent, MouseHook
which are implemented for Windows. Need to review it.
5de9858
to
25ed92e
Compare
dd54772
to
03e6396
Compare
Codecov Report
@@ Coverage Diff @@
## atspi #1213 +/- ##
===========================================
- Coverage 87.88% 75.64% -12.25%
===========================================
Files 60 70 +10
Lines 23019 24491 +1472
===========================================
- Hits 20231 18525 -1706
- Misses 2788 5966 +3178 |
d48ce03
to
e8eaeec
Compare
0dd9195
to
31f2d43
Compare
Thanks @vasily-v-ryabov ! What is remaining in order for this to be merged? |
First conflicts should be resolved, also Circle CI should be used with SIP-disabled image to enable accessibility programmatically, then |
No description provided.