Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap qt app install command, add 4 more libs #14

Merged
merged 14 commits into from
Jun 18, 2024

Conversation

tlambert03
Copy link
Contributor

closes #13

as a shot in the dark, this PR wraps the command to install qt-libs in action.yml, it also added four more libraries that are present in setup-qt-libs, which may be used in certain Qt applications

  • libdbus-1-3
  • libegl1-mesa
  • libxcb-xinput0
  • x11-utils

@tlambert03
Copy link
Contributor Author

@larsoner ... possible that the actions aren't running due to inactivity here?

@larsoner
Copy link
Collaborator

Yep just reenabled, can you push an empty commit?

@larsoner
Copy link
Collaborator

Also you can see the tests are super basic... if you have widely used modules that would catch some of those new system libraries feel free to add them (but not required)

@tlambert03
Copy link
Contributor Author

yeah, I'm afraid it's been a while since I determined the list that I used in setup-qt-libs... i'll dig for a moment and see if I can find a good test case, but may give up :)

@larsoner
Copy link
Collaborator

Hah, tests fail because the macos-latest now means macos-14. I'll open a separate PR to fix CIs while you look!

@tlambert03
Copy link
Contributor Author

side-note, d5e79a9 bumped the action versions and changed python 3.9 to 3.10 (needed unless we want to use an older macos runner)

@tlambert03
Copy link
Contributor Author

ah ok :) will undo here

@larsoner
Copy link
Collaborator

There is a conflict, I can fix it if you want or feel free to push

@tlambert03
Copy link
Contributor Author

no worries, got it.

@tlambert03 tlambert03 mentioned this pull request Jun 18, 2024
@larsoner larsoner merged commit 26bf0f1 into pyvista:main Jun 18, 2024
10 checks passed
@larsoner
Copy link
Collaborator

Thanks @tlambert03 !

@tlambert03
Copy link
Contributor Author

thanks!

@tlambert03
Copy link
Contributor Author

will follow up with better tests in #17

@tlambert03 tlambert03 deleted the wrap-and-add branch June 18, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libxcb-cursor0 oddly not getting installed
2 participants