Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchx - add exception_type and exception_message to torchx event #966

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tonykao8080
Copy link
Contributor

Summary: Add exception type and message to torchx event. This allows for better logging of exception details for further analysis.

Differential Revision: D64406552

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64406552

…location to torchx event (pytorch#966)

Summary:

Add exception type, exception message, exception source location to torchx event. This allows for better logging of exception details for further analysis.

Differential Revision: D64406552
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64406552

Copy link
Contributor

@andywag andywag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Sanjay-Ganeshan Sanjay-Ganeshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonykao8080 tonykao8080 merged commit af5acd6 into pytorch:main Oct 16, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants