Add missing workspace docs #961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Ultimately we want to remove all the docs under https://www.internalfb.com/intern/wiki/TorchX_internal/TorchX and consolidate it all in the staticdocs wiki. This diff moves the info from https://www.internalfb.com/intern/wiki/TorchX_internal/TorchX/How_Patching_Works/ into the patching wiki page, and also does some nice formatting. Note: I mostly ignored the stuff under the deprecated custom patch section, if anyone knows more about this, please let me know if there's anything in there that should be moved over and/or if any of the stuff in this wiki is wrong. Reviewed By: ishachirimar Differential Revision: D63643254
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63643254 |
jesszzzz
added a commit
to jesszzzz/torchx
that referenced
this pull request
Oct 9, 2024
Summary: Ultimately we want to remove all the docs under https://www.internalfb.com/intern/wiki/TorchX_internal/TorchX and consolidate it all in the staticdocs wiki. This diff moves the info from https://www.internalfb.com/intern/wiki/TorchX_internal/TorchX/How_Patching_Works/ into the patching wiki page, and also does some nice formatting. Note: I mostly ignored the stuff under the deprecated custom patch section, if anyone knows more about this, please let me know if there's anything in there that should be moved over and/or if any of the stuff in this wiki is wrong. Reviewed By: ishachirimar Differential Revision: D63643254
tonykao8080
approved these changes
Oct 9, 2024
yikaiMeta
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ultimately we want to remove all the docs under https://www.internalfb.com/intern/wiki/TorchX_internal/TorchX and consolidate it all in the staticdocs wiki.
This diff moves the info from https://www.internalfb.com/intern/wiki/TorchX_internal/TorchX/How_Patching_Works/ into the patching wiki page, and also does some nice formatting.
Note: I mostly ignored the stuff under the deprecated custom patch section, if anyone knows more about this, please let me know if there's anything in there that should be moved over and/or if any of the stuff in this wiki is wrong.
Reviewed By: ishachirimar
Differential Revision: D63643254