Make torchx scheduler opts support enums#870
Open
andywag wants to merge 1 commit intometa-pytorch:mainfrom
Open
Make torchx scheduler opts support enums#870andywag wants to merge 1 commit intometa-pytorch:mainfrom
andywag wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Mar 31, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
andywag
force-pushed
the
export-D55551233
branch
from
bd12c44 to
820ea58
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Mar 31, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
andywag
force-pushed
the
export-D55551233
branch
from
820ea58 to
64524dd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Apr 1, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
andywag
force-pushed
the
export-D55551233
branch
from
64524dd to
e8715ab
Compare
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Apr 1, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
andywag
force-pushed
the
export-D55551233
branch
from
e8715ab to
b9573f0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
force-pushed
the
export-D55551233
branch
from
b9573f0 to
aee0801
Compare
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Apr 1, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Apr 1, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
andywag
force-pushed
the
export-D55551233
branch
from
aee0801 to
da0152a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Apr 2, 2024
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
andywag
force-pushed
the
export-D55551233
branch
from
da0152a to
5e1d68d
Compare
Summary: Added Support for Enumerations in scheduler options. This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums. Differential Revision: D55551233
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
andywag
force-pushed
the
export-D55551233
branch
from
5e1d68d to
4227419
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55551233 |
yikaiMeta
approved these changes
Apr 9, 2024
kiukchung
requested changes
Apr 12, 2024
| opt_type: Type[CfgVal] | ||
| is_required: bool | ||
| help: str | ||
| creator: Optional[Callable[[CfgVal], CfgVal]] = None |
Contributor
There was a problem hiding this comment.
Its not clear how to use this creator. Can/should I use a creator for a primitive CfgVal (eg ones that are not enums)?
In general schedule options were kept dead simple because they are meant to be directly parsable from command-line (after all torchx is mostly used from CLI). This is why they are not structured, and only basic type checking is done for sanity. Enums are tricky to support especially when the values are sent over the wire and as such support for enums in scheduler opts should be well motivated and thorougly justified as we would be trading off simplicity/clarity for .
I'd like to understand the motivation behind wanting to support enums for scheduler opts before we add them. cc @d4l3k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added Support for Enumerations in scheduler options.
This is a bit more generic as it takes in a creator function which converts a CfgVal to another type. There are some limitations on how general it can be based on how the typing is setup. This also makes it tricky to make a convenience function to handle only Enums.
Differential Revision: D55551233