Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer Accuracy API #664

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update to newer Accuracy API #664

wants to merge 5 commits into from

Conversation

priyaramani
Copy link
Contributor

@priyaramani priyaramani commented Dec 8, 2022

Instead of pinning torchmetrics library, use their updated latest APIs

Test plan:
CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #664 (34c8712) into main (e5da2be) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   94.50%   94.51%   +0.01%     
==========================================
  Files          71       75       +4     
  Lines        5094     5108      +14     
==========================================
+ Hits         4814     4828      +14     
  Misses        280      280              
Impacted Files Coverage Δ
torchx/pipelines/__init__.py 100.00% <0.00%> (ø)
torchx/pipelines/kfp/__init__.py 100.00% <0.00%> (ø)
torchx/version.py 100.00% <0.00%> (ø)
torchx/__init__.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@priyaramani priyaramani changed the title pin cryptography Fix broken tests Dec 9, 2022
@priyaramani priyaramani changed the title Fix broken tests Update to newer Accuracy API Dec 9, 2022
@facebook-github-bot
Copy link
Contributor

@priyaramani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants