Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kfp and lightning dependencies #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update kfp and lightning dependencies #577

wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Aug 5, 2022

This bumps the kfp and lightning versions. The previous diff only bumped lightning but had a dependency incompatibility for typing-extensions. #574

Test plan:

CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2022
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #577 (d005ff3) into main (515a265) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          67       67           
  Lines        4047     4047           
=======================================
  Hits         3835     3835           
  Misses        212      212           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@facebook-github-bot
Copy link
Contributor

Hi @d4l3k!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants